[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 309fc74c257f6ffe6fd5c131ca6631e531716639..9834b07991d699e79d1dcb6656394924f670149e 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -35,7 +35,13 @@ class ManagePasswordsUIController
   // can handle later requests to save or blacklist that login information.
   // This stores the provided object in form_manager_ and triggers the UI to
   // prompt the user about whether they would like to save the password.
-  void OnPasswordSubmitted(password_manager::PasswordFormManager* form_manager);
+  void OnPasswordSubmitted(
+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
+
+  // Called when the password will be saved automatically, but we still wish to
+  // visually inform the user that the save has occured.
+  void OnAutomaticPasswordSave(
+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
 
   // Called when a form is autofilled with login information, so we can manage
   // password credentials for the current site which are stored in
@@ -71,6 +77,9 @@ class ManagePasswordsUIController
   // Open a new tab, pointing to the password manager settings page.
   virtual void NavigateToPasswordManagerSettingsPage();
 
+  // Open a new tab, pointing to the Google manage passwords website.
+  virtual void NavigateToAccountCentralManagementPage();
+
   virtual const autofill::PasswordForm& PendingCredentials() const;
 
   // Set the state of the Omnibox icon, and possibly show the associated bubble
@@ -83,7 +92,7 @@ class ManagePasswordsUIController
   // or not to save it.
   bool PasswordPendingUserDecision() const;
 
-  const autofill::PasswordFormMap best_matches() const {
+  const autofill::ConstPasswordFormMap best_matches() const {
     return password_form_map_;
   }
 
@@ -103,11 +112,11 @@ class ManagePasswordsUIController
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
-  // All previously stored credentials for a specific site. Set by
-  // OnPasswordSubmitted(), OnPasswordAutofilled(), or
-  // OnBlacklistBlockedAutofill(). Protected, not private, so we can mess with
-  // the value in ManagePasswordsUIControllerMock.
-  autofill::PasswordFormMap password_form_map_;
+  // All previously stored credentials for a specific site. This is not
+  // physically const, but the contents of the maps should be treated as const.
+  // Protected, not private, so we can mess with the value in
+  // ManagePasswordsUIControllerMock.

[Mike West, 2014/07/17 13:43:17]

You can kill this bit of the comment, right?

[Garrett Casto, 2014/07/17 20:54:55]

Yep, done.

+  autofill::ConstPasswordFormMap password_form_map_;
 
   // We create copies of PasswordForm objects that come in via OnLoginsChanged()
   // and store them in this vector as well as in |password_form_map_| to ensure