[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
@@ skipping 17 matching lines @@
     : public content::WebContentsObserver,
       public content::WebContentsUserData<ManagePasswordsUIController>,
       public password_manager::PasswordStore::Observer {
  public:
   virtual ~ManagePasswordsUIController();
 
   // Called when the user submits a form containing login information, so we
   // can handle later requests to save or blacklist that login information.
   // This stores the provided object in form_manager_ and triggers the UI to
   // prompt the user about whether they would like to save the password.
-  void OnPasswordSubmitted(password_manager::PasswordFormManager* form_manager);
+  void OnPasswordSubmitted(
+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
+
+  // Called when the password will be saved automatically, but we still wish to
+  // visually inform the user that the save has occured.
+  void OnAutomaticPasswordSave(
+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
 
   // Called when a form is autofilled with login information, so we can manage
   // password credentials for the current site which are stored in
   // |password_form_map|. This stores a copy of |password_form_map| and shows
   // the manage password icon.
   void OnPasswordAutofilled(const autofill::PasswordFormMap& password_form_map);
 
   // Called when a form is _not_ autofilled due to user blacklisting. This
   // stores a copy of |password_form_map| so that we can offer the user the
   // ability to reenable the manager for this form.
@@ skipping 15 matching lines @@
   virtual void NeverSavePassword();
 
   // Called from the model when the user chooses to unblacklist the site. The
   // controller MUST be in BLACKLIST_STATE, and WILL be in MANAGE_STATE after
   // this method executes.
   virtual void UnblacklistSite();
 
   // Open a new tab, pointing to the password manager settings page.
   virtual void NavigateToPasswordManagerSettingsPage();
 
+  // Open a new tab, pointing to the Google manage passwords website.
+  virtual void NavigateToAccountCentralManagementPage();
+
   virtual const autofill::PasswordForm& PendingCredentials() const;
 
   // Set the state of the Omnibox icon, and possibly show the associated bubble
   // without user interaction.
   virtual void UpdateIconAndBubbleState(ManagePasswordsIcon* icon);
 
   password_manager::ui::State state() const { return state_; }
 
   // True if a password is sitting around, waiting for a user to decide whether
   // or not to save it.
   bool PasswordPendingUserDecision() const;
 
-  const autofill::PasswordFormMap best_matches() const {
+  const autofill::ConstPasswordFormMap best_matches() const {
     return password_form_map_;
   }
 
   const GURL& origin() const { return origin_; }
 
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
   virtual void NeverSavePasswordInternal();
 
   // content::WebContentsObserver:
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
-  // All previously stored credentials for a specific site. Set by
-  // OnPasswordSubmitted(), OnPasswordAutofilled(), or
-  // OnBlacklistBlockedAutofill(). Protected, not private, so we can mess with
-  // the value in ManagePasswordsUIControllerMock.
-  autofill::PasswordFormMap password_form_map_;
+  // All previously stored credentials for a specific site. This is not
+  // physically const, but the contents of the maps should be treated as const.
+  // Protected, not private, so we can mess with the value in
+  // ManagePasswordsUIControllerMock.

[Mike West, 2014/07/17 13:43:17]

You can kill this bit of the comment, right?

[Garrett Casto, 2014/07/17 20:54:55]

Yep, done.

+  autofill::ConstPasswordFormMap password_form_map_;
 
   // We create copies of PasswordForm objects that come in via OnLoginsChanged()
   // and store them in this vector as well as in |password_form_map_| to ensure
   // that we destroy them correctly.
   ScopedVector<autofill::PasswordForm> new_password_forms_;
 
   // The current state of the password manager. Protected so we can manipulate
   // the value in tests.
   password_manager::ui::State state_;
 
@@ skipping 29 matching lines @@
 
   // The origin of the form we're currently dealing with; we'll use this to
   // determine which PasswordStore changes we should care about when updating
   // |password_form_map_|.
   GURL origin_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_