[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 309fc74c257f6ffe6fd5c131ca6631e531716639..8ab7a6804c77c2dfdab88db04c280ec287026972 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -37,6 +37,12 @@ class ManagePasswordsUIController
   // prompt the user about whether they would like to save the password.
   void OnPasswordSubmitted(password_manager::PasswordFormManager* form_manager);
 
+  // Called when the password will be saved automatically, but we still wish to
+  // visually inform the user that the save has occured. Currently shows the
+  // manage password UI.
+  void ShowSaveConfirmation(

[Garrett Casto, 2014/07/16 06:29:00]

I don't like the fact that this name is prescriptive while the others are
descriptive.  It could be changed to something like
OnGeneratedPasswordSubmitted(), but I was hoping for a name that makes sense for
both generated and auto saved passwords. Suggestions welcome.

[Mike West, 2014/07/16 07:55:03]

"OnAutomaticPasswordSave"? Best I can come up with off the top of my head. :)

[Garrett Casto, 2014/07/17 06:42:45]

It'll do. Changed.

+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
+
   // Called when a form is autofilled with login information, so we can manage
   // password credentials for the current site which are stored in
   // |password_form_map|. This stores a copy of |password_form_map| and shows
@@ -103,10 +109,10 @@ class ManagePasswordsUIController
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
-  // All previously stored credentials for a specific site. Set by
-  // OnPasswordSubmitted(), OnPasswordAutofilled(), or
-  // OnBlacklistBlockedAutofill(). Protected, not private, so we can mess with
-  // the value in ManagePasswordsUIControllerMock.
+  // All previously stored credentials for a specific site. This is not
+  // physically const, but the contents of the maps should be treated as const.

[Mike West, 2014/07/16 07:55:03]

Would it be worth creating an `autofill::ConstPasswordFormMap` or something
similar in a future CL?

[Garrett Casto, 2014/07/17 06:42:45]

I thought about that, but was wasn't sure how viral the change would be. Turns
out it's not to bad. I feel like there is probably a one line way to convert
PasswordFormMap -> ConstPasswordFormMap, but I'm not sure what it is.

+  // Protected, not private, so we can mess with the value in
+  // ManagePasswordsUIControllerMock.
   autofill::PasswordFormMap password_form_map_;
 
   // We create copies of PasswordForm objects that come in via OnLoginsChanged()