[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
@@ skipping 19 matching lines @@
       public password_manager::PasswordStore::Observer {
  public:
   virtual ~ManagePasswordsUIController();
 
   // Called when the user submits a form containing login information, so we
   // can handle later requests to save or blacklist that login information.
   // This stores the provided object in form_manager_ and triggers the UI to
   // prompt the user about whether they would like to save the password.
   void OnPasswordSubmitted(password_manager::PasswordFormManager* form_manager);
 
+  // Called when the password will be saved automatically, but we still wish to
+  // visually inform the user that the save has occured. Currently shows the
+  // manage password UI.
+  void ShowSaveConfirmation(

[Garrett Casto, 2014/07/16 06:29:00]

I don't like the fact that this name is prescriptive while the others are
descriptive.  It could be changed to something like
OnGeneratedPasswordSubmitted(), but I was hoping for a name that makes sense for
both generated and auto saved passwords. Suggestions welcome.

[Mike West, 2014/07/16 07:55:03]

"OnAutomaticPasswordSave"? Best I can come up with off the top of my head. :)

[Garrett Casto, 2014/07/17 06:42:45]

It'll do. Changed.

+      scoped_ptr<password_manager::PasswordFormManager> form_manager);
+
   // Called when a form is autofilled with login information, so we can manage
   // password credentials for the current site which are stored in
   // |password_form_map|. This stores a copy of |password_form_map| and shows
   // the manage password icon.
   void OnPasswordAutofilled(const autofill::PasswordFormMap& password_form_map);
 
   // Called when a form is _not_ autofilled due to user blacklisting. This
   // stores a copy of |password_form_map| so that we can offer the user the
   // ability to reenable the manager for this form.
   void OnBlacklistBlockedAutofill(
@@ skipping 46 matching lines @@
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
   virtual void NeverSavePasswordInternal();
 
   // content::WebContentsObserver:
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
-  // All previously stored credentials for a specific site. Set by
-  // OnPasswordSubmitted(), OnPasswordAutofilled(), or
-  // OnBlacklistBlockedAutofill(). Protected, not private, so we can mess with
-  // the value in ManagePasswordsUIControllerMock.
+  // All previously stored credentials for a specific site. This is not
+  // physically const, but the contents of the maps should be treated as const.

[Mike West, 2014/07/16 07:55:03]

Would it be worth creating an `autofill::ConstPasswordFormMap` or something
similar in a future CL?

[Garrett Casto, 2014/07/17 06:42:45]

I thought about that, but was wasn't sure how viral the change would be. Turns
out it's not to bad. I feel like there is probably a one line way to convert
PasswordFormMap -> ConstPasswordFormMap, but I'm not sure what it is.

+  // Protected, not private, so we can mess with the value in
+  // ManagePasswordsUIControllerMock.
   autofill::PasswordFormMap password_form_map_;
 
   // We create copies of PasswordForm objects that come in via OnLoginsChanged()
   // and store them in this vector as well as in |password_form_map_| to ensure
   // that we destroy them correctly.
   ScopedVector<autofill::PasswordForm> new_password_forms_;
 
   // The current state of the password manager. Protected so we can manipulate
   // the value in tests.
   password_manager::ui::State state_;
@@ skipping 30 matching lines @@
 
   // The origin of the form we're currently dealing with; we'll use this to
   // determine which PasswordStore changes we should care about when updating
   // |password_form_map_|.
   GURL origin_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_