Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 399343003: Make WebContents get the correct screen coordinates when initially added. (Closed)

Created:
6 years, 5 months ago by calamity
Modified:
6 years, 5 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make WebContents get the correct screen coordinates when initially added. This CL fixes an issue where combobox dropdowns would render in the wrong place for tabs that were created in the background. This was happening because the native view and clipping windows weren't being added in the right order, causing the incorrect screen space coordinates to get passed around. BUG=394715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284913

Patch Set 1 : #

Patch Set 2 : set kHostViewKey earlier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M ui/views/controls/native/native_view_host_aura.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/native/native_view_host_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
calamity
6 years, 5 months ago (2014-07-22 07:42:02 UTC) #1
sky
LGTM I don't think this effects estade's patch, but adding just in case.
6 years, 5 months ago (2014-07-22 16:57:46 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 5 months ago (2014-07-23 03:03:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/399343003/40001
6 years, 5 months ago (2014-07-23 03:04:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 06:20:50 UTC) #5
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 5 months ago (2014-07-23 07:50:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/399343003/60001
6 years, 5 months ago (2014-07-23 07:51:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 09:35:30 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:09:50 UTC) #9
Message was sent while issue was closed.
Change committed as 284913

Powered by Google App Engine
This is Rietveld 408576698