ui/views/controls/native/native_view_host_aura.cc - Issue 399343003: Make WebContents get the correct screen coordinates when initially added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/native/native_view_host_aura.cc

Issue 399343003: Make WebContents get the correct screen coordinates when initially added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set kHostViewKey earlier Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/native/native_view_host_aura.cc

diff --git a/ui/views/controls/native/native_view_host_aura.cc b/ui/views/controls/native/native_view_host_aura.cc

index f690f0574fae9569ff7a6eb73c9470770e691d34..2e06f50c42a2fee1d77423eb6d6d59c410f8398b 100644

--- a/ui/views/controls/native/native_view_host_aura.cc

+++ b/ui/views/controls/native/native_view_host_aura.cc

@@ -147,14 +147,14 @@ void NativeViewHostAura::AddClippingWindow() {

RemoveClippingWindow();

gfx::Rect bounds = host_->native_view()->bounds();

+ host_->native_view()->SetProperty(aura::client::kHostWindowKey,

+ host_->GetWidget()->GetNativeView());

+ Widget::ReparentNativeView(host_->native_view(),

+ &clipping_window_);

if (host_->GetWidget()->GetNativeView()) {

Widget::ReparentNativeView(&clipping_window_,

host_->GetWidget()->GetNativeView());

}

- host_->native_view()->SetProperty(aura::client::kHostWindowKey,

- host_->GetWidget()->GetNativeView());

- Widget::ReparentNativeView(host_->native_view(),

- &clipping_window_);

clipping_window_.SetBounds(bounds);

bounds.set_origin(gfx::Point(0, 0));

host_->native_view()->SetBounds(bounds);

« no previous file with comments | « no previous file | ui/views/controls/native/native_view_host_unittest.cc » ('j') | no next file with comments »