| Index: tools/telemetry/telemetry/results/page_measurement_results_unittest.py
|
| diff --git a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
|
| index 12662a7a6492bf309863e11eb61cec4ecc64e99c..51980eae3111f26dc4fbaf6f65fda73229bfb294 100644
|
| --- a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
|
| +++ b/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
|
| @@ -7,6 +7,7 @@ import unittest
|
| from telemetry import perf_tests_helper
|
| from telemetry.page import page_set
|
| from telemetry.results import page_measurement_results
|
| +from telemetry.value import failure
|
| from telemetry.value import histogram
|
| from telemetry.value import scalar
|
|
|
| @@ -112,12 +113,12 @@ class PageMeasurementResultsTest(unittest.TestCase):
|
| results.WillMeasurePage(self.pages[0])
|
| results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
|
| results.DidMeasurePage()
|
| - results.AddFailureMessage(self.pages[0], 'message')
|
| + results.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'message'))
|
|
|
| results.WillMeasurePage(self.pages[1])
|
| results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 7))
|
| results.DidMeasurePage()
|
| - results.AddFailureMessage(self.pages[1], 'message')
|
| + results.AddValue(failure.FailureValue.FromMessage(self.pages[1], 'message'))
|
|
|
| results.PrintSummary()
|
| self.assertEquals(results.results, [])
|
| @@ -158,7 +159,7 @@ class PageMeasurementResultsTest(unittest.TestCase):
|
| results.DidMeasurePage()
|
|
|
| results.WillMeasurePage(self.pages[1])
|
| - results.AddFailureMessage(self.pages[1], "Failure")
|
| + results.AddValue(failure.FailureValue.FromMessage(self.pages[1], 'Failure'))
|
| results.DidMeasurePage()
|
|
|
| results.WillMeasurePage(self.pages[2])
|
| @@ -166,6 +167,7 @@ class PageMeasurementResultsTest(unittest.TestCase):
|
| results.DidMeasurePage()
|
|
|
| values = results.all_page_specific_values
|
| - self.assertEquals(2, len(values))
|
| - self.assertEquals([self.pages[0], self.pages[2]],
|
| - [v.page for v in values])
|
| + self.assertEquals(3, len(values))
|
| + self.assertEquals(
|
| + [self.pages[0], self.pages[2]], results.pages_that_succeeded)
|
| + self.assertEquals([self.pages[1]], results.pages_that_had_failures)
|
|
|