tools/telemetry/telemetry/results/page_measurement_results.py - Issue 399263003: Add FailureValue and wire it through PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/gtest_test_results_unittest.py ('k') | tools/telemetry/telemetry/results/page_measurement_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/page_measurement_results.py

diff --git a/tools/telemetry/telemetry/results/page_measurement_results.py b/tools/telemetry/telemetry/results/page_measurement_results.py

index abaf784ba3ac73a10f2697e65e21913477485507..dea7b2489452ad8d8caa6a6622f8e94c3bc539c4 100644

--- a/tools/telemetry/telemetry/results/page_measurement_results.py

+++ b/tools/telemetry/telemetry/results/page_measurement_results.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

from telemetry.results import page_test_results

+from telemetry.value import failure

class PageMeasurementResults(page_test_results.PageTestResults):

def __init__(self, output_stream=None, trace_tag=''):

@@ -28,7 +29,8 @@ class PageMeasurementResults(page_test_results.PageTestResults):

def AddValue(self, value):

super(PageMeasurementResults, self).AddValue(value)

- self._page_specific_values_for_current_page.append(value)

+ if not isinstance(value, failure.FailureValue):

+ self._page_specific_values_for_current_page.append(value)

def DidMeasurePage(self):

assert self._current_page, 'Failed to call WillMeasurePage'