Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 399143006: Check for unused variables in GN. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Check for unused variables in GN. A check for unused variables was missing for some helper functions. The main thing that this affects is the "config" function, where people were confused when setting deps or configs didn't work the way they expected (because they were unused). BUG=392026 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/yasm/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
This also depends on WebKit patch https://codereview.chromium.org/403653002/ The yasm code was pretty suspicious. I believe ...
6 years, 5 months ago (2014-07-18 00:20:40 UTC) #1
Dirk Pranke
rubberstamp lgtm :).
6 years, 5 months ago (2014-07-21 20:14:19 UTC) #2
brettw
6 years, 5 months ago (2014-07-21 21:48:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r284509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698