Open the WrenchMenu on mouseover when dragging a browser action

ui/views/controls/menu/menu_runner.cc

Index: ui/views/controls/menu/menu_runner.cc
diff --git a/ui/views/controls/menu/menu_runner.cc b/ui/views/controls/menu/menu_runner.cc
index 4adaed724421caddcd0ba30932dfb4ef421c2297..44f35685f2198d2cf0a6ea85abbbedf6e3cfe341 100644
--- a/ui/views/controls/menu/menu_runner.cc
+++ b/ui/views/controls/menu/menu_runner.cc
@@ -175,7 +175,7 @@ MenuRunner::RunResult MenuRunnerImpl::RunMenuAt(Widget* parent,
 
   running_ = true;
   for_drop_ = (types & MenuRunner::FOR_DROP) != 0;
-  bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0 && !for_drop_;

[sky, 2014/07/18 19:36:54]

Why are you removing this?

[Devlin, 2014/07/18 21:38:31]

(Please double check me on this)

If the menu has mnemonics, we hide the prefix unless we specifically want to
show it. [1]  (Showing the prefix results in the ampersand being visible, e.g.
"New &Tab".)  Since the menu opening for a drop doesn't (so far as I can tell)
affect whether or not the menu actually has mnemonics, this check results in the
mnemonics being shown during a drag-and-drop session, despite show_mnemonics
always being false.

Is there a better way to fix this?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/controls/...

[sky, 2014/07/18 22:45:39]

Ok, that makes sense.

+  bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0;
   owns_controller_ = false;
   if (!controller) {
     // No menus are showing, show one.