Open the WrenchMenu on mouseover when dragging a browser action

ui/views/controls/menu/menu_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_runner.h"
 
 #include <set>
 
 #include "base/memory/weak_ptr.h"
 #include "ui/base/models/menu_model.h"
@@ skipping 157 matching lines @@
         return MenuRunner::NORMAL_EXIT;
       }
       // Drop menus don't block the message loop, so it's ok to create a new
       // MenuController.
       controller = NULL;
     }
   }
 
   running_ = true;
   for_drop_ = (types & MenuRunner::FOR_DROP) != 0;
-  bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0 && !for_drop_;

[sky, 2014/07/18 19:36:54]

Why are you removing this?

[Devlin, 2014/07/18 21:38:31]

(Please double check me on this)

If the menu has mnemonics, we hide the prefix unless we specifically want to
show it. [1]  (Showing the prefix results in the ampersand being visible, e.g.
"New &Tab".)  Since the menu opening for a drop doesn't (so far as I can tell)
affect whether or not the menu actually has mnemonics, this check results in the
mnemonics being shown during a drag-and-drop session, despite show_mnemonics
always being false.

Is there a better way to fix this?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/controls/...

[sky, 2014/07/18 22:45:39]

Ok, that makes sense.

+  bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0;
   owns_controller_ = false;
   if (!controller) {
     // No menus are showing, show one.
     ui::NativeTheme* theme = parent ? parent->GetNativeTheme() :
         ui::NativeTheme::instance();
     controller = new MenuController(theme, !for_drop_, this);
     owns_controller_ = true;
   }
   controller->set_is_combobox((types & MenuRunner::COMBOBOX) != 0);
   controller_ = controller;
@@ skipping 151 matching lines @@
 base::TimeDelta MenuRunner::closing_event_time() const {
   return holder_->closing_event_time();
 }
 
 void MenuRunner::SetRunnerHandler(
     scoped_ptr<MenuRunnerHandler> runner_handler) {
   runner_handler_ = runner_handler.Pass();
 }
 
 }  // namespace views