ui/views/controls/menu/menu_runner.cc - Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner.cc

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for drag/drop not in menu Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_runner.cc

diff --git a/ui/views/controls/menu/menu_runner.cc b/ui/views/controls/menu/menu_runner.cc

index 4adaed724421caddcd0ba30932dfb4ef421c2297..44f35685f2198d2cf0a6ea85abbbedf6e3cfe341 100644

--- a/ui/views/controls/menu/menu_runner.cc

+++ b/ui/views/controls/menu/menu_runner.cc

@@ -175,7 +175,7 @@ MenuRunner::RunResult MenuRunnerImpl::RunMenuAt(Widget* parent,

running_ = true;

for_drop_ = (types & MenuRunner::FOR_DROP) != 0;

- bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0 && !for_drop_;

+ bool has_mnemonics = (types & MenuRunner::HAS_MNEMONICS) != 0;

owns_controller_ = false;

if (!controller) {

// No menus are showing, show one.

« ui/views/controls/menu/menu_controller.h ('K') | « ui/views/controls/menu/menu_delegate.cc ('k') | no next file » | no next file with comments »