ui/views/controls/menu/menu_controller.h - Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.h

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for drag/drop not in menu Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/toolbar/toolbar_view.cc ('K') | « chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/menu/menu_controller.h

diff --git a/ui/views/controls/menu/menu_controller.h b/ui/views/controls/menu/menu_controller.h

index 1a4c195a74b200bdc90e1c8e97c9603d86154eac..6c2303a6793a72bdf39e4a7faa89e642a4dc7275 100644

--- a/ui/views/controls/menu/menu_controller.h

+++ b/ui/views/controls/menu/menu_controller.h

@@ -402,6 +402,9 @@ class VIEWS_EXPORT MenuController : public WidgetObserver {

void StartCancelAllTimer();

void StopCancelAllTimer();

+ // Closes the menu because a drag left the view.

Finnur 2014/07/18 10:40:40 Drag (noun), pronounced /drag/. "a boring or tires

Devlin 2014/07/18 15:44:32 Haha fair enough. :) I'd like to stick to drag-an

Finnur 2014/07/18 15:53:51 Yup, what you have now is good.

+ void CancelAllForDrag();

// Calculates the bounds of the menu to show. is_leading is set to match the

// direction the menu opened in.

gfx::Rect CalculateMenuBounds(MenuItemView* item,