Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3553)

Unified Diff: chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for drag/drop not in menu Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc b/chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc
index ab2e704113e1a7ad9e289e54d211d443d44ba33f..6018c0d5321f8f11fc28f6658c854c26f341e7a6 100644
--- a/chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc
@@ -4,14 +4,25 @@
#include "chrome/browser/ui/views/toolbar/wrench_toolbar_button.h"
+#include "base/message_loop/message_loop.h"
+#include "base/time/time.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/views/extensions/browser_action_drag_data.h"
+#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
+#include "extensions/common/feature_switch.h"
#include "grit/theme_resources.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/theme_provider.h"
+#include "ui/views/metrics.h"
#include "ui/views/painter.h"
-WrenchToolbarButton::WrenchToolbarButton(views::MenuButtonListener* listener)
- : views::MenuButton(NULL, base::string16(), listener, false) {
- wrench_icon_painter_.reset(new WrenchIconPainter(this));
+WrenchToolbarButton::WrenchToolbarButton(ToolbarView* toolbar_view)
+ : views::MenuButton(NULL, base::string16(), toolbar_view, false),
+ wrench_icon_painter_(new WrenchIconPainter(this)),
+ toolbar_view_(toolbar_view),
+ allow_extension_dragging_(
+ extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()),
+ weak_factory_(this) {
}
WrenchToolbarButton::~WrenchToolbarButton() {
@@ -38,3 +49,50 @@ void WrenchToolbarButton::OnPaint(gfx::Canvas* canvas) {
void WrenchToolbarButton::ScheduleWrenchIconPaint() {
SchedulePaint();
}
+
+bool WrenchToolbarButton::GetDropFormats(
+ int* formats, std::set<ui::OSExchangeData::CustomFormat>* custom_formats) {
+ return allow_extension_dragging_ ?
+ BrowserActionDragData::GetDropFormats(custom_formats) :
+ views::View::GetDropFormats(formats, custom_formats);
+}
+bool WrenchToolbarButton::AreDropTypesRequired() {
+ return allow_extension_dragging_ ?
+ BrowserActionDragData::AreDropTypesRequired() :
+ views::View::AreDropTypesRequired();
+}
+bool WrenchToolbarButton::CanDrop(const ui::OSExchangeData& data) {
+ return allow_extension_dragging_ ?
+ BrowserActionDragData::CanDrop(data,
+ toolbar_view_->browser()->profile()) :
+ views::View::CanDrop(data);
+}
+
+void WrenchToolbarButton::OnDragEntered(const ui::DropTargetEvent& event) {
+ DCHECK(allow_extension_dragging_);
+ DCHECK(!weak_factory_.HasWeakPtrs());
+ base::MessageLoop::current()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&WrenchToolbarButton::ShowOverflowMenu,
+ weak_factory_.GetWeakPtr()),
+ base::TimeDelta::FromMilliseconds(views::GetMenuShowDelay()));
+}
+
+int WrenchToolbarButton::OnDragUpdated(const ui::DropTargetEvent& event) {
+ DCHECK(allow_extension_dragging_);
+ return ui::DragDropTypes::DRAG_MOVE;
+}
+
+void WrenchToolbarButton::OnDragExited() {
+ DCHECK(allow_extension_dragging_);
+ weak_factory_.InvalidateWeakPtrs();
+}
+
+int WrenchToolbarButton::OnPerformDrop(const ui::DropTargetEvent& event) {
+ DCHECK(allow_extension_dragging_);
+ return ui::DragDropTypes::DRAG_MOVE;
+}
+
+void WrenchToolbarButton::ShowOverflowMenu() {
+ toolbar_view_->ShowAppMenu(true); // For drop.
+}

Powered by Google App Engine
This is Rietveld 408576698