Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8558)

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_view.h

Issue 399143004: Open the WrenchMenu on mouseover when dragging a browser action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for drag/drop not in menu Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_action_view.h
diff --git a/chrome/browser/ui/views/toolbar/browser_action_view.h b/chrome/browser/ui/views/toolbar/browser_action_view.h
index 24ff613d8d368e0756ccdad03925c33a1308090b..ebba98b64107d0fea4529847e44c933006613466 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_view.h
+++ b/chrome/browser/ui/views/toolbar/browser_action_view.h
@@ -57,6 +57,10 @@ class BrowserActionView : public views::View {
// Whether the container for this button is shown inside a menu.
virtual bool ShownInsideMenu() const = 0;
+ // Notifies that a drag completed. Note this will only happen if the view
+ // wasn't removed during the drag-and-drop process.
Finnur 2014/07/18 10:40:40 ... as in the extension being uninstalled?
Devlin 2014/07/18 15:44:32 Not quite. We delete and recreate all the views e
+ virtual void OnBrowserActionViewDragDone() = 0;
+
protected:
virtual ~Delegate() {}
};
@@ -201,6 +205,7 @@ class BrowserActionButton : public views::MenuButton,
// Overridden from views::View:
virtual void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) OVERRIDE;
+ virtual void OnDragDone() OVERRIDE;
private:
virtual ~BrowserActionButton();

Powered by Google App Engine
This is Rietveld 408576698