Open the WrenchMenu on mouseover when dragging a browser action

chrome/browser/ui/views/toolbar/browser_action_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_
 
 #include <string>
 
 #include "chrome/browser/extensions/extension_action_icon_factory.h"
@@ skipping 39 matching lines @@
 
     // Called when the user clicks on the browser action icon.
     virtual void OnBrowserActionExecuted(BrowserActionButton* button) = 0;
 
     // Called when a browser action becomes visible/hidden.
     virtual void OnBrowserActionVisibilityChanged() = 0;
 
     // Whether the container for this button is shown inside a menu.
     virtual bool ShownInsideMenu() const = 0;
 
+    // Notifies that a drag completed. Note this will only happen if the view
+    // wasn't removed during the drag-and-drop process.

[Finnur, 2014/07/18 10:40:40]

... as in the extension being uninstalled?

[Devlin, 2014/07/18 15:44:32]

Not quite.  We delete and recreate all the views every time there's a change in
the browser actions order.  Which is kinda excessive (and results in an ugly
"flicker" on repaint), but that's a separate issue to fix. :)  Problem is, the
view is only notified that the drag is done if it wasn't deleted as part of the
drag - which these are if there's actually a movement.

Comment updated to make it more clear.

+    virtual void OnBrowserActionViewDragDone() = 0;
+
    protected:
     virtual ~Delegate() {}
   };
 
   BrowserActionView(const extensions::Extension* extension,
                     Browser* browser,
                     Delegate* delegate);
   virtual ~BrowserActionView();
 
   BrowserActionButton* button() { return button_; }
@@ skipping 124 matching lines @@
   // Gets the icon of this button and its badge.
   gfx::ImageSkia GetIconWithBadge();
 
   // Returns button icon so it can be accessed during tests.
   gfx::ImageSkia GetIconForTest();
 
  protected:
   // Overridden from views::View:
   virtual void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) OVERRIDE;
+  virtual void OnDragDone() OVERRIDE;
 
  private:
   virtual ~BrowserActionButton();
 
   // Register an extension command if the extension has an active one.
   void MaybeRegisterExtensionCommand();
 
   // Unregisters an extension command, if the extension has registered one and
   // it is active.
   void MaybeUnregisterExtensionCommand(bool only_if_active);
@@ skipping 33 matching lines @@
   // The observer that we need to notify when the icon of the button has been
   // updated.
   IconObserver* icon_observer_;
 
   friend class base::DeleteHelper<BrowserActionButton>;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserActionButton);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_ACTION_VIEW_H_