Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: chrome/browser/autocomplete/base_search_provider.h

Issue 399063002: Remove BaseSearchProvider::set_in_app_list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.h
diff --git a/chrome/browser/autocomplete/base_search_provider.h b/chrome/browser/autocomplete/base_search_provider.h
index 522fcf971b330f67a574358e524cbee184893fee..c95a945db4fd44515e47d6ffb3114b5dd4e95bec 100644
--- a/chrome/browser/autocomplete/base_search_provider.h
+++ b/chrome/browser/autocomplete/base_search_provider.h
@@ -76,8 +76,6 @@ class BaseSearchProvider : public AutocompleteProvider,
return field_trial_triggered_in_session_;
}
- void set_in_app_list() { in_app_list_ = true; }
-
protected:
// The following keys are used to record additional information on matches.
@@ -340,7 +338,6 @@ class BaseSearchProvider : public AutocompleteProvider,
// |append_extra_query_params| should be set if |template_url| is the default
// search engine, so the destination URL will contain any
// command-line-specified query params.
- // |from_app_list| should be set if the search was made from the app list.
static AutocompleteMatch CreateSearchSuggestion(
AutocompleteProvider* autocomplete_provider,
const AutocompleteInput& input,
@@ -348,8 +345,7 @@ class BaseSearchProvider : public AutocompleteProvider,
const TemplateURL* template_url,
const SearchTermsData& search_terms_data,
int accepted_suggestion,
- bool append_extra_query_params,
- bool from_app_list);
+ bool append_extra_query_params);
// Parses JSON response received from the provider, stripping XSSI
// protection if needed. Returns the parsed data if successful, NULL
@@ -517,11 +513,6 @@ class BaseSearchProvider : public AutocompleteProvider,
// causes us to auto-cancel all such requests on shutdown.
SuggestionDeletionHandlers deletion_handlers_;
- // True if this provider's results are being displayed in the app list. By
- // default this is false, meaning that the results will be shown in the
- // omnibox.
- bool in_app_list_;
-
DISALLOW_COPY_AND_ASSIGN(BaseSearchProvider);
};
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('k') | chrome/browser/autocomplete/base_search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698