Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/autocomplete/base_search_provider.cc

Issue 399063002: Remove BaseSearchProvider::set_in_app_list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.cc
diff --git a/chrome/browser/autocomplete/base_search_provider.cc b/chrome/browser/autocomplete/base_search_provider.cc
index 44982ec44680ad34e8e5709bbd6817497617ba73..17e9b2511854c1e4548d7cf5dfafed88fb7f1b8b 100644
--- a/chrome/browser/autocomplete/base_search_provider.cc
+++ b/chrome/browser/autocomplete/base_search_provider.cc
@@ -133,8 +133,7 @@ BaseSearchProvider::BaseSearchProvider(AutocompleteProviderListener* listener,
profile_(profile),
field_trial_triggered_(false),
field_trial_triggered_in_session_(false),
- suggest_results_pending_(0),
- in_app_list_(false) {
+ suggest_results_pending_(0) {
}
// static
@@ -154,7 +153,7 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
suggestion, type, suggestion, base::string16(), base::string16(),
base::string16(), base::string16(), std::string(), std::string(),
from_keyword_provider, 0, false, false, base::string16()),
- template_url, search_terms_data, 0, false, false);
+ template_url, search_terms_data, 0, false);
}
void BaseSearchProvider::Stop(bool clear_cached_results) {
@@ -482,8 +481,7 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
const TemplateURL* template_url,
const SearchTermsData& search_terms_data,
int accepted_suggestion,
- bool append_extra_query_params,
- bool from_app_list) {
+ bool append_extra_query_params) {
AutocompleteMatch match(autocomplete_provider, suggestion.relevance(), false,
suggestion.type());
@@ -540,7 +538,6 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
suggestion.suggest_query_params();
match.search_terms_args->append_extra_query_params =
append_extra_query_params;
- match.search_terms_args->from_app_list = from_app_list;
// This is the destination URL sans assisted query stats. This must be set
// so the AutocompleteController can properly de-dupe; the controller will
// eventually overwrite it before it reaches the user.
@@ -716,7 +713,7 @@ void BaseSearchProvider::AddMatchToMap(const SuggestResult& result,
this, GetInput(result.from_keyword_provider()), result,
GetTemplateURL(result.from_keyword_provider()),
UIThreadSearchTermsData(profile_), accepted_suggestion,
- ShouldAppendExtraParams(result), in_app_list_);
+ ShouldAppendExtraParams(result));
if (!match.destination_url.is_valid())
return;
match.search_terms_args->bookmark_bar_pinned =
« no previous file with comments | « chrome/browser/autocomplete/base_search_provider.h ('k') | chrome/browser/ui/app_list/search/omnibox_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698