Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 399033002: Web Animations: Don't compare start time for AnimationPlayer sorting (Closed)

Created:
6 years, 5 months ago by Timothy Loh
Modified:
6 years, 5 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Web Animations: Don't compare start time for AnimationPlayer sorting As per recent spec changes, the start time should no longer factor in to AnimationPlayer sort order. I've left in the SortInfo class instead of simply holding on to an unsigned sequence number since we may in the future add a mechanism for changing sort order, although this is easy to remove later if won't be adding such functionality. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178531

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -59 lines) Patch
M Source/core/animation/AnimationPlayer.h View 1 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 3 chunks +1 line, -12 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 1 1 chunk +1 line, -21 lines 0 comments Download
M Source/core/animation/AnimationStack.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 3 chunks +6 lines, -15 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Timothy Loh
6 years, 5 months ago (2014-07-17 04:18:32 UTC) #1
alancutter (OOO until 2018)
lgtm Add link to relevant spec in the description: http://www.w3.org/TR/web-animations/#the-animation-stack
6 years, 5 months ago (2014-07-17 05:57:14 UTC) #2
dstockwell
lgtm
6 years, 5 months ago (2014-07-18 01:02:30 UTC) #3
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 5 months ago (2014-07-18 01:03:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/399033002/1
6 years, 5 months ago (2014-07-18 01:04:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 02:20:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 02:32:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/6473)
6 years, 5 months ago (2014-07-18 02:32:04 UTC) #8
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 5 months ago (2014-07-21 00:38:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/399033002/1
6 years, 5 months ago (2014-07-21 00:39:26 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-21 00:41:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 00:43:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/6760)
6 years, 5 months ago (2014-07-21 00:44:00 UTC) #13
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 5 months ago (2014-07-21 01:35:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/399033002/20001
6 years, 5 months ago (2014-07-21 01:35:45 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 02:36:41 UTC) #16
Message was sent while issue was closed.
Change committed as 178531

Powered by Google App Engine
This is Rietveld 408576698