Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: Source/core/animation/AnimationPlayerTest.cpp

Issue 399033002: Web Animations: Don't compare start time for AnimationPlayer sorting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationPlayer.cpp ('k') | Source/core/animation/AnimationStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationPlayerTest.cpp
diff --git a/Source/core/animation/AnimationPlayerTest.cpp b/Source/core/animation/AnimationPlayerTest.cpp
index d625a2d4af05851b724dbc32520aa53e40cb3f42..40a46570bd466f4021ed8e62293202e7d9f438ba 100644
--- a/Source/core/animation/AnimationPlayerTest.cpp
+++ b/Source/core/animation/AnimationPlayerTest.cpp
@@ -709,29 +709,9 @@ TEST_F(AnimationAnimationPlayerTest, AttachedAnimationPlayers)
TEST_F(AnimationAnimationPlayerTest, HasLowerPriority)
{
- // Sort time defaults to timeline current time
- updateTimeline(15);
RefPtrWillBeRawPtr<AnimationPlayer> player1 = timeline->createAnimationPlayer(0);
RefPtrWillBeRawPtr<AnimationPlayer> player2 = timeline->createAnimationPlayer(0);
- player2->setStartTimeInternal(10);
- RefPtrWillBeRawPtr<AnimationPlayer> player3 = timeline->createAnimationPlayer(0);
- RefPtrWillBeRawPtr<AnimationPlayer> player4 = timeline->createAnimationPlayer(0);
- player4->setStartTimeInternal(20);
- RefPtrWillBeRawPtr<AnimationPlayer> player5 = timeline->createAnimationPlayer(0);
- player5->setStartTimeInternal(10);
- RefPtrWillBeRawPtr<AnimationPlayer> player6 = timeline->createAnimationPlayer(0);
- player6->setStartTimeInternal(-10);
- Vector<RefPtrWillBeMember<AnimationPlayer> > players;
- players.append(player6);
- players.append(player2);
- players.append(player5);
- players.append(player1);
- players.append(player3);
- players.append(player4);
- for (size_t i = 0; i < players.size(); i++) {
- for (size_t j = 0; j < players.size(); j++)
- EXPECT_EQ(i < j, AnimationPlayer::hasLowerPriority(players[i].get(), players[j].get()));
- }
+ EXPECT_TRUE(AnimationPlayer::hasLowerPriority(player1.get(), player2.get()));
}
}
« no previous file with comments | « Source/core/animation/AnimationPlayer.cpp ('k') | Source/core/animation/AnimationStack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698