Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 398873004: ui: Cleanup the generated path to ui strings. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, brettw
Project:
chromium
Visibility:
Public.

Description

ui: Cleanup the generated path to ui strings. This makes things much more clearer and in order with the rest of strings/grit targets. BUG=323025 TEST=None R=tony@chromium.org,lcwu@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284024

Patch Set 1 #

Patch Set 2 : REABSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M apps/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/chromecast.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/ui_strings.gyp View 1 chunk +6 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
Hi Tony, could you review this to me? Thanks,
6 years, 5 months ago (2014-07-17 00:53:03 UTC) #1
tony
LGTM, but please run it through the try bots.
6 years, 5 months ago (2014-07-17 00:55:44 UTC) #2
lcwu1
lgtm for chromecast repack_cast_shell_pack changes.
6 years, 5 months ago (2014-07-17 01:07:34 UTC) #3
lcwu1
On 2014/07/17 01:07:34, lcwu1 wrote: > lgtm for chromecast repack_cast_shell_pack changes. Ah, in fact a ...
6 years, 5 months ago (2014-07-17 01:37:31 UTC) #4
tfarina
On 2014/07/17 01:37:31, lcwu1 wrote: > On 2014/07/17 01:07:34, lcwu1 wrote: > > lgtm for ...
6 years, 5 months ago (2014-07-17 01:42:20 UTC) #5
gunsch
On 2014/07/17 01:42:20, tfarina wrote: > On 2014/07/17 01:37:31, lcwu1 wrote: > > On 2014/07/17 ...
6 years, 5 months ago (2014-07-17 04:05:38 UTC) #6
tfarina
TBRing Ben for this...
6 years, 5 months ago (2014-07-18 02:34:22 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-18 02:34:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/398873004/20001
6 years, 5 months ago (2014-07-18 02:35:55 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 07:14:26 UTC) #10
Message was sent while issue was closed.
Change committed as 284024

Powered by Google App Engine
This is Rietveld 408576698