Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 396733002: Fixes chromecast build to point to ui/resources and ui/strings. (Closed)

Created:
6 years, 5 months ago by gunsch
Modified:
6 years, 5 months ago
Reviewers:
lcwu1, brettw
CC:
chromium-reviews, ozone-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes chromecast build to point to ui/resources and ui/strings. Adapts to changes in https://codereview.chromium.org/381113004. R=lcwu@chromium.org,brettw@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283632

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 13 (0 generated)
gunsch
6 years, 5 months ago (2014-07-15 18:56:48 UTC) #1
lcwu1
lgtm
6 years, 5 months ago (2014-07-15 21:38:31 UTC) #2
gunsch
brettw, ping? None of us on chromecast/ are committers yet, we just need a rubberstamp ...
6 years, 5 months ago (2014-07-16 16:22:46 UTC) #3
brettw
lgtm
6 years, 5 months ago (2014-07-16 18:08:33 UTC) #4
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 5 months ago (2014-07-16 18:30:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/396733002/1
6 years, 5 months ago (2014-07-16 18:31:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:47:53 UTC) #7
lcwu1
https://codereview.chromium.org/396733002/diff/1/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/396733002/diff/1/chromecast/chromecast.gyp#newcode84 chromecast/chromecast.gyp:84: '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings/app_locale_settings_en-US.pak', Based on https://codereview.chromium.org/398873004/,this should be changed to "ui/strings/app_locale_settings_en-US.pak" ...
6 years, 5 months ago (2014-07-17 01:41:14 UTC) #8
lcwu1
The CQ bit was unchecked by lcwu@chromium.org
6 years, 5 months ago (2014-07-17 01:41:33 UTC) #9
tfarina
fyi -> https://codereview.chromium.org/398873004/ I will wait on this to land, and will rebase mine after ...
6 years, 5 months ago (2014-07-17 01:41:53 UTC) #10
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 5 months ago (2014-07-17 02:38:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/396733002/1
6 years, 5 months ago (2014-07-17 02:42:54 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:03:49 UTC) #13
Message was sent while issue was closed.
Change committed as 283632

Powered by Google App Engine
This is Rietveld 408576698