Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 398873003: Adds dynamic setting of FEC group size based on the connection's current (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana
Project:
chromium
Visibility:
Public.

Description

Adds dynamic setting of FEC group size based on the connection's current congestion window. There will be two triggers for transmitted an FEC packet, when protection is required -- max_packets_per_fec_group, and an FEC alarm that triggers an FEC packet if the FEC group has been open for long enough. This CL implements dynamically setting max_packets_per_fec_group. The FEC alarm will be written in a subsequent CL. Merge internal change: 70821636 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -39 lines) Patch
M net/quic/quic_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M net/quic/quic_packet_generator.h View 4 chunks +8 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +33 lines, -12 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +67 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 3 chunks +19 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +18 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 15 chunks +45 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-16 22:06:09 UTC) #1
Ryan Hamilton
6 years, 5 months ago (2014-07-17 00:02:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698