Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/quic/quic_packet_creator.h

Issue 398873003: Adds dynamic setting of FEC group size based on the connection's current (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.h
diff --git a/net/quic/quic_packet_creator.h b/net/quic/quic_packet_creator.h
index ecab1e6d745a2d2f8508102d845bf12c5348928b..cd6c587277d00b7a7d4621d76b8a3afc8091e8cb 100644
--- a/net/quic/quic_packet_creator.h
+++ b/net/quic/quic_packet_creator.h
@@ -225,11 +225,10 @@ class NET_EXPORT_PRIVATE QuicPacketCreator : public QuicFecBuilderInterface {
}
// Sets creator's max number of packets covered by an FEC group.
- void set_max_packets_per_fec_group(size_t max_packets_per_fec_group) {
- // To turn off FEC protection, use StopFecProtectingPackets().
- DCHECK_NE(0u, max_packets_per_fec_group);
- max_packets_per_fec_group_ = max_packets_per_fec_group;
- }
+ // Note: While there are no constraints on |max_packets_per_fec_group|,
+ // this setter enforces a min value of kLowestMaxPacketsPerFecGroup.
+ // To turn off FEC protection, use StopFecProtectingPackets().
+ void set_max_packets_per_fec_group(size_t max_packets_per_fec_group);
private:
friend class test::QuicPacketCreatorPeer;
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698