Move AddValue/AddSummaryValue to PageTestResults.

Move AddValue/AddSummaryValue to PageTestResults.

This is needed for FailureValue patch (so that one can call
AddValue(FailureValue)). This also brings us closer to merging
PageTestResults and PageMeasurementResults -- to kill the rest of the
methods, we will need to make more progress on merging PageTest and
PageMeasurement.

Unit tests aren't moved because they still depend on
{Will,Did}MeasurePage.

Additional cleanup: kill dead code in page_measurement_results.py
(self._done).

BUG=383635, 392901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283785

[chrishenry, 2014-07-15 21:22:01]

This depends on https://codereview.chromium.org/381303002/.

[nednguyen, 2014-07-15 21:30:28]

lgtm

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/gtest_test_results.py (right):

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/gtest_test_results.py:28: raise
Exception('GTestTestResults does not support AddValue().')
Why can't this just use page_test_results's implementation?

[chrishenry, 2014-07-15 21:50:39]

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/gtest_test_results.py (right):

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/gtest_test_results.py:28: raise
Exception('GTestTestResults does not support AddValue().')
On 2014/07/15 21:30:28, nednguyen wrote:
> Why can't this just use page_test_results's implementation?

GTestTestResults drops these values. I don't think we should be dropping values.
WDYT?

[nednguyen, 2014-07-15 23:13:19]

On 2014/07/15 21:50:39, chrishenry wrote:
>
https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
> File tools/telemetry/telemetry/results/gtest_test_results.py (right):
> 
>
https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
> tools/telemetry/telemetry/results/gtest_test_results.py:28: raise
> Exception('GTestTestResults does not support AddValue().')
> On 2014/07/15 21:30:28, nednguyen wrote:
> > Why can't this just use page_test_results's implementation?
> 
> GTestTestResults drops these values. I don't think we should be dropping
values.
> WDYT?
Ok. GTestTestResults probably doesn't add any value rather than FailureValue.

[nednguyen, 2014-07-15 23:34:05]

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/gtest_test_results.py (right):

https://codereview.chromium.org/398583002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/gtest_test_results.py:28: raise
Exception('GTestTestResults does not support AddValue().')
On 2014/07/15 21:50:39, chrishenry wrote:
> On 2014/07/15 21:30:28, nednguyen wrote:
> > Why can't this just use page_test_results's implementation?
> 
> GTestTestResults drops these values. I don't think we should be dropping
values.
> WDYT?
Actually it seems like we can make ValidateValue private in page_test_results
and ignore this method here?

[chrishenry, 2014-07-17 13:28:11]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-17 13:29:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/398583002/20001

[commit-bot: I haz the power, 2014-07-17 15:38:29]

Change committed as 283785