tools/telemetry/telemetry/results/buildbot_page_measurement_results.py - Issue 398583002: Move AddValue/AddSummaryValue to PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

Issue 398583002: Move AddValue/AddSummaryValue to PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

index da1624123bc3346d09cff3e0a31418611534f957..fef9933830a4a2fe53d7da775a2cb73c6814061d 100644

--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

@@ -80,7 +80,7 @@ class BuildbotPageMeasurementResults(

# If there were no failed pages, output the overall results (results not

# associated with a page).

if not self.had_failures:

- for value in self._all_summary_values:

+ for value in self.all_summary_values:

buildbot_value = value.GetBuildbotValue()

buildbot_data_type = value.GetBuildbotDataType(

output_context=value_module.SUMMARY_RESULT_OUTPUT_CONTEXT)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/gtest_test_results.py » ('j') | no next file with comments »