Issue 398543003: Initialise the OpenSSL RNG in the Zygote.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398543003: Initialise the OpenSSL RNG in the Zygote. (Closed)

Created:
6 years, 5 months ago by agl

Modified:
5 years, 7 months ago

Reviewers:
jln (very slow on Chromium), jam

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Initialise the OpenSSL RNG in the Zygote. BoringSSL aborts rather than returning bad entropy and this is causing crashes. On Android, the sandbox isn't blocking access and so there wasn't a problem. BUG=395224

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	content/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/zygote/zygote_main_linux.cc	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

jln: for the zygote change. jam: for the DEPS change to allow OpenSSL/BoringSSL headers to ...

6 years, 5 months ago (2014-07-18 19:37:38 UTC) #1

jam

On 2014/07/18 19:37:38, agl wrote: > jln: for the zygote change. > > jam: for ...

6 years, 5 months ago (2014-07-18 21:39:36 UTC) #2

jln (very slow on Chromium)

6 years, 5 months ago (2014-07-18 22:04:46 UTC) #3

lgtm, but do you think at some point BoringSSL could provide a better API for
this?

Something like "PreSandboxResourceAcquire()" instead of warming up by doing
crypto.

Expand Messages | Collapse Messages