Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 398333002: Concurrent/parallel precise sweeping. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)
Modified:
6 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Concurrent/parallel precise sweeping. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22471

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -83 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/mark-compact.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 2 3 4 21 chunks +130 lines, -49 lines 0 comments Download
M src/spaces.h View 1 4 chunks +15 lines, -16 lines 0 comments Download
M src/spaces.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-18 06:46:15 UTC) #1
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-18 06:46:15 UTC) #2
Jarin
https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc#newcode3237 src/mark-compact.cc:3237: return space->Free(start, size); Could we ASSERT(free_list == NULL) here? ...
6 years, 5 months ago (2014-07-18 08:31:30 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/398333002/diff/60001/src/mark-compact.cc#newcode3237 src/mark-compact.cc:3237: return space->Free(start, size); On 2014/07/18 08:31:29, jarin wrote: > ...
6 years, 5 months ago (2014-07-18 10:47:20 UTC) #4
Jarin
lgtm
6 years, 5 months ago (2014-07-18 10:54:11 UTC) #5
Hannes Payer (out of office)
6 years, 5 months ago (2014-07-18 11:04:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r22471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698