Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: src/heap.cc

Issue 398333002: Concurrent/parallel precise sweeping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index 5c7cbcacd3d4c3e028b347ae9cd42e1d79b825b2..fec0ac0a099ce56ef6d06602349e0755ec6b3add 100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -1301,7 +1301,7 @@ static void VerifyNonPointerSpacePointers(Heap* heap) {
// The old data space was normally swept conservatively so that the iterator
// doesn't work, so we normally skip the next bit.
- if (heap->old_data_space()->is_iterable()) {
+ if (heap->old_data_space()->swept_precisely()) {
HeapObjectIterator data_it(heap->old_data_space());
for (HeapObject* object = data_it.Next();
object != NULL; object = data_it.Next())
@@ -3312,8 +3312,7 @@ bool Heap::CanMoveObjectStart(HeapObject* object) {
// pages is set after sweeping all pages.
return (!is_in_old_pointer_space && !is_in_old_data_space) ||
page->WasSwept() ||
- (page->parallel_sweeping() <=
- MemoryChunk::PARALLEL_SWEEPING_FINALIZE);
+ (page->parallel_sweeping() <= MemoryChunk::SWEEPING_FINALIZE);
}
@@ -4217,8 +4216,8 @@ STRUCT_LIST(MAKE_CASE)
bool Heap::IsHeapIterable() {
- return (old_pointer_space()->is_iterable() &&
- old_data_space()->is_iterable() &&
+ return (old_pointer_space()->swept_precisely() &&
+ old_data_space()->swept_precisely() &&
new_space_top_after_last_gc_ == new_space()->top());
}
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698