Issue 398323002: Fix Mac build with disable_nacl=1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398323002: Fix Mac build with disable_nacl=1. (Closed)

Created:
6 years, 5 months ago by Joao da Silva

Modified:
6 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix Mac build with disable_nacl=1. switches::kNaClLoaderProcess is referenced by chrome_main_delegate.cc but isn't found by the linker. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283771

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
	M	chrome/app/chrome_main_delegate.cc	View	1	6 chunks	+23 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

Joao da Silva

PTAL. This file hasn't changed recently; I guess this regressed due to some change in ...

6 years, 5 months ago (2014-07-17 10:10:23 UTC) #1

Joao da Silva

It regressed yesterday at https://codereview.chromium.org/321423002, in the change to chrome/common_constants.gyp.

6 years, 5 months ago (2014-07-17 10:13:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/398323002/20001

6 years, 5 months ago (2014-07-17 13:00:52 UTC) #5

Message was sent while issue was closed.

Change committed as 283771