Drop NaCl dependencies on platforms where disable_nacl=1.

Drop NaCl dependencies on platforms where disable_nacl=1.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283505

[bradnelson, 2014-07-16 00:54:01]

lgtm with one concern about ios.
Sorry, noticed this fell on the floor.

https://codereview.chromium.org/321423002/diff/170001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (left):

https://codereview.chromium.org/321423002/diff/170001/chrome/chrome_common.gy...
chrome/chrome_common.gypi:390: ['exclude', '^common/nacl_'],
don't we still want this to exclude nacl on ios?

[Lei Zhang, 2014-07-16 01:32:11]

https://codereview.chromium.org/321423002/diff/170001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (left):

https://codereview.chromium.org/321423002/diff/170001/chrome/chrome_common.gy...
chrome/chrome_common.gypi:390: ['exclude', '^common/nacl_'],
On 2014/07/16 00:54:01, bradnelson wrote:
> don't we still want this to exclude nacl on ios?

There's no source files that match the regex.

[Lei Zhang, 2014-07-16 01:32:17]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:33:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/321423002/170001

[Lei Zhang, 2014-07-16 01:36:57]

On 2014/07/16 01:32:11, Lei Zhang wrote:
> There's no source files that match the regex.

I should have mentioned this. It wasn't obvious to me either either, but then I
remembered.

Also, 29 hour is a perfectly good response time. I started this CL a month ago
but forgot to send it out.

[commit-bot: I haz the power, 2014-07-16 04:25:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-16 04:38:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 04:38:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[Lei Zhang, 2014-07-16 06:57:38]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-16 06:58:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/321423002/190001

[commit-bot: I haz the power, 2014-07-16 11:41:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-16 11:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 11:45:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Lei Zhang, 2014-07-16 17:57:04]

palmer: Can I have a stamp for the trivial message change?

[palmer, 2014-07-16 20:51:28]

lgtm

[Lei Zhang, 2014-07-16 20:59:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-16 21:06:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/321423002/190001

[commit-bot: I haz the power, 2014-07-16 21:13:59]

Change committed as 283505

[tzik, 2014-07-17 05:01:30]

A revert of this CL has been created in
https://codereview.chromium.org/401583002/ by tzik@chromium.org.

The reason for reverting is: This seems to cause build failure on disable_nacl=1
build.
There are still some dependency to NaCl switches like:
https://chromium.googlesource.com/chromium/src/+/b9b8f9cf116b0608b3f3f19a9953...
https://chromium.googlesource.com/chromium/src/+/b9b8f9cf116b0608b3f3f19a9953....

[Joao da Silva, 2014-07-17 10:14:43]

Had the same problem today. Fix at https://codereview.chromium.org/398323002;
this can be relanded with that fix or after the fix lands on its own.

[Lei Zhang, 2014-07-17 17:43:29]

On 2014/07/17 10:14:43, Joao da Silva wrote:
> Had the same problem today. Fix at https://codereview.chromium.org/398323002;
> this can be relanded with that fix or after the fix lands on its own.

The revert didn't actually happen, so let's just fix up the broken pieces. I was
relying too much on the bots to test possible configurations.