Gallery: Random fixes for the Viewport class.

Gallery: Random fixes for the Viewport class.

The CL do:

* Remove the device rect argument from paintDeviceRect because the rectangle can
be calculated from other arguments.

* Remove setByFrame(AndFit) helper functions that are used only once each to simplify
the Viewport class.

* Rename getScreenClipped with getImageBoundsOnScreenClipped. The old name
  sounds it retuns the bounds of screen.

* Add getImageElementBounds to obtain the bounds before applying zoom and
  offset.

BUG=245926
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283719

[hirono, 2014-07-17 05:26:16]

* Remove the device rect argument from paintDeviceRect because the rectangle can
be calculated from other arguments.

[hirono, 2014-07-17 05:30:56]

PTAL the CL? Thank you!

[mtomasz, 2014-07-17 05:43:21]

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:148: return this.left +
this.width;
I think it should be:
this.left + this.width - 1.

Eg. For rect: left = 0, top = 0, width = 1, height = 1.
The right most pixel is at 0 position, not 1.

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_view.js:181: *     may not be
fullresolution (scaled).
nit: fullresolution -> full resolution

[hirono, 2014-07-17 05:56:47]

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:148: return this.left +
this.width;
On 2014/07/17 05:43:20, mtomasz wrote:
> I think it should be:
> this.left + this.width - 1.
> 
> Eg. For rect: left = 0, top = 0, width = 1, height = 1.
> The right most pixel is at 0 position, not 1.

Exactly. but the right edge of the pixel is a line (x = 1).
The number is not a position of pixel, it is the coordinate value of the right
edge. The definition is sometimes convenient to calculate geometry. e.g. var
center = (rect.left + rect.right) / 2; WDYT?

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_view.js:181: *     may not be
fullresolution (scaled).
On 2014/07/17 05:43:20, mtomasz wrote:
> nit: fullresolution -> full resolution

Done.

[mtomasz, 2014-07-17 06:08:57]

lgtm with nits

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:144: * Obtains the x
coordinate number of right edge.
nit: Please add a comment, that the edge is one pixel after the last pixel, or
sth like that.

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:148: return this.left +
this.width;
On 2014/07/17 05:56:47, hirono wrote:
> On 2014/07/17 05:43:20, mtomasz wrote:
> > I think it should be:
> > this.left + this.width - 1.
> > 
> > Eg. For rect: left = 0, top = 0, width = 1, height = 1.
> > The right most pixel is at 0 position, not 1.
> 
> Exactly. but the right edge of the pixel is a line (x = 1).
> The number is not a position of pixel, it is the coordinate value of the right
> edge. The definition is sometimes convenient to calculate geometry. e.g. var
> center = (rect.left + rect.right) / 2; WDYT?

This is quite confusing. The left edge is within the image, but the right
outside. However, seems that SkRect in Chromium uses the same logic, so I'm fine
with it.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/i...

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:152: * Obtains the y
coordinate number of bottom edge.
nit: coordinate number -> coordinate

[hirono, 2014-07-17 06:26:54]

Thank you!

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:144: * Obtains the x
coordinate number of right edge.
On 2014/07/17 06:08:56, mtomasz wrote:
> nit: Please add a comment, that the edge is one pixel after the last pixel, or
> sth like that.

Done.

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:148: return this.left +
this.width;
On 2014/07/17 06:08:56, mtomasz wrote:
> On 2014/07/17 05:56:47, hirono wrote:
> > On 2014/07/17 05:43:20, mtomasz wrote:
> > > I think it should be:
> > > this.left + this.width - 1.
> > > 
> > > Eg. For rect: left = 0, top = 0, width = 1, height = 1.
> > > The right most pixel is at 0 position, not 1.
> > 
> > Exactly. but the right edge of the pixel is a line (x = 1).
> > The number is not a position of pixel, it is the coordinate value of the
right
> > edge. The definition is sometimes convenient to calculate geometry. e.g. var
> > center = (rect.left + rect.right) / 2; WDYT?
> 
> This is quite confusing. The left edge is within the image, but the right
> outside. However, seems that SkRect in Chromium uses the same logic, so I'm
fine
> with it.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/i...

Maybe this is common when implementing rectangle class. I also saw the logic in
.NET.
http://msdn.microsoft.com/en-us//library/system.windows.rect.right(v=vs.110)....

https://codereview.chromium.org/398263002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_util.js:152: * Obtains the y
coordinate number of bottom edge.
On 2014/07/17 06:08:56, mtomasz wrote:
> nit: coordinate number -> coordinate

Done.

[hirono, 2014-07-17 06:27:26]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-07-17 06:28:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/398263002/20001

[commit-bot: I haz the power, 2014-07-17 08:57:17]

Change committed as 283719