Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 398183002: Fix alpha textures in NV ES3 contexts on Windows (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix alpha textures in NV ES3 contexts on Windows. Make unit tests iterate over all the rendering GL context types rather than using kNative. Fix the extension printing when gStartupSpew is set. Committed: https://skia.googlesource.com/skia/+/e904c09a3a9c701e8d91f2f6ee161feda7615d90

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix no-gpu build #

Patch Set 4 : suppress warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -306 lines) Patch
M src/gpu/gl/GrGLContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 2 chunks +12 lines, -6 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 2 2 chunks +113 lines, -83 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +67 lines, -59 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 chunk +19 lines, -7 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +115 lines, -104 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 2 chunks +65 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
This is prep work for moving from a single gpu config to gl and gles ...
6 years, 5 months ago (2014-07-16 20:25:13 UTC) #1
jvanverth1
lgtm
6 years, 5 months ago (2014-07-17 15:28:26 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-17 15:46:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/398183002/40001
6 years, 5 months ago (2014-07-17 15:47:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-17 16:03:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 16:07:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/3321)
6 years, 5 months ago (2014-07-17 16:07:26 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-17 17:39:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/398183002/60001
6 years, 5 months ago (2014-07-17 17:39:37 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 17:51:05 UTC) #10
Message was sent while issue was closed.
Change committed as e904c09a3a9c701e8d91f2f6ee161feda7615d90

Powered by Google App Engine
This is Rietveld 408576698