Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 398043005: Scroll interruption tests for CSSOM View smooth scroll (Closed)

Created:
6 years, 5 months ago by ajuma
Modified:
6 years, 5 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Scroll interruption tests for CSSOM View smooth scroll This adds a SmoothScrollInterruptionTest class and tests using this class. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178387 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178481

Patch Set 1 : #

Patch Set 2 : Fix listbox test on Mac #

Messages

Total messages: 12 (0 generated)
ajuma
6 years, 5 months ago (2014-07-16 19:11:22 UTC) #1
Ian Vollick
On 2014/07/16 19:11:22, ajuma wrote: lgtm.
6 years, 5 months ago (2014-07-17 16:06:15 UTC) #2
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 5 months ago (2014-07-17 16:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/398043005/20001
6 years, 5 months ago (2014-07-17 16:48:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 17:54:33 UTC) #5
commit-bot: I haz the power
Change committed as 178387
6 years, 5 months ago (2014-07-17 18:27:24 UTC) #6
abarth-chromium
A revert of this CL has been created in https://codereview.chromium.org/400763003/ by abarth@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-17 19:48:18 UTC) #7
ajuma
PTAL. The timeout on Mac was caused by an interaction with http://crrev.com/347773002, which changes listbox ...
6 years, 5 months ago (2014-07-18 15:56:41 UTC) #8
Ian Vollick
On 2014/07/18 15:56:41, ajuma wrote: > PTAL. The timeout on Mac was caused by an ...
6 years, 5 months ago (2014-07-18 19:49:16 UTC) #9
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 5 months ago (2014-07-18 19:53:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/398043005/40001
6 years, 5 months ago (2014-07-18 19:54:45 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 19:58:10 UTC) #12
Message was sent while issue was closed.
Change committed as 178481

Powered by Google App Engine
This is Rietveld 408576698