Issue 398003: linux: Use gtk-cursor-blink from GtkSettings to set the caret blink interval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398003: linux: Use gtk-cursor-blink from GtkSettings to set the caret blink interval (Closed)

Created:
11 years, 1 month ago by Joel Stanley

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: Use gtk-cursor-blink from GtkSettings to set the caret blink interval BUG=20772 TEST=Open gnome-keyboard-properties. Un-set the "Cursor Blinking" checkbox. Open a new tab in chromium and the cursor should not blink. Do the same with the slider, and the rate of blinking should vary.

Patch Set 1 #

Patch Set 2 : fixes #

Total comments: 1

Patch Set 3 : latest #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	chrome/common/gtk_util.cc	View	1 2	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/renderer_preferences.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Joel Stanley

goes with webkit api patch: https://bugs.webkit.org/show_bug.cgi?id=31704

11 years, 1 month ago (2009-11-20 05:07:25 UTC) #1

Evan Martin

LGTM (after other change goes in) http://codereview.chromium.org/398003/diff/1001/2002 File chrome/common/render_messages.h (right): http://codereview.chromium.org/398003/diff/1001/2002#newcode1586 Line 1586: return false; ...

11 years, 1 month ago (2009-11-20 05:23:49 UTC) #2

Joel Stanley

On 2009/11/20 05:23:49, Evan Martin wrote: > LGTM (after other change goes in) The upstream ...

10 years, 10 months ago (2010-02-04 12:30:27 UTC) #3

LGTM

Expand Messages | Collapse Messages