Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397933003: Service Workers: Clean up cpplint.py warnings (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 5 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Service Workers: Clean up cpplint.py warnings All trivial. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -31 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
cpplint didn't find any real issues (yay!) but might as well land these nit fixes. ...
6 years, 5 months ago (2014-07-17 21:29:21 UTC) #1
michaeln
lgtm (sorry i didn't notice this earlier?)
6 years, 5 months ago (2014-07-18 19:26:54 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 5 months ago (2014-07-18 19:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/397933003/1
6 years, 5 months ago (2014-07-18 19:30:07 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:46:32 UTC) #5
Message was sent while issue was closed. 
Change committed as 284212

Powered by Google App Engine
This is Rietveld 408576698