Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job.cc

Issue 397933003: Service Workers: Clean up cpplint.py warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_read_from_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_read_from_cache_job.cc b/content/browser/service_worker/service_worker_read_from_cache_job.cc
index a10b4a9894d0832a0e947307a156159273c3914f..c0dbc82ad5900710255b7adce0e036f4133f49e5 100644
--- a/content/browser/service_worker/service_worker_read_from_cache_job.cc
+++ b/content/browser/service_worker/service_worker_read_from_cache_job.cc
@@ -4,6 +4,9 @@
#include "content/browser/service_worker/service_worker_read_from_cache_job.h"
+#include <string>
+#include <vector>
+
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_disk_cache.h"
#include "content/browser/service_worker/service_worker_metrics.h"
@@ -134,13 +137,13 @@ const net::HttpResponseInfo* ServiceWorkerReadFromCacheJob::http_info() const {
void ServiceWorkerReadFromCacheJob::OnReadInfoComplete(int result) {
scoped_refptr<ServiceWorkerReadFromCacheJob> protect(this);
if (!http_info_io_buffer_->http_info) {
- DCHECK(result < 0);
+ DCHECK_LT(result, 0);
ServiceWorkerMetrics::CountReadResponseResult(
ServiceWorkerMetrics::READ_HEADERS_ERROR);
NotifyDone(net::URLRequestStatus(net::URLRequestStatus::FAILED, result));
return;
}
- DCHECK(result >= 0);
+ DCHECK_GE(result, 0);
SetStatus(net::URLRequestStatus()); // Clear the IO_PENDING status
http_info_.reset(http_info_io_buffer_->http_info.release());
if (is_range_request())

Powered by Google App Engine
This is Rietveld 408576698