Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/app_sorting.h

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review
Patch Set: Changed implementation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_sorting.h
diff --git a/extensions/browser/app_sorting.h b/extensions/browser/app_sorting.h
index 75edf637477917e565459ecd6d4ac2248f51e17a..2761fef8e80d772eebea9dea75153dd320bb4874 100644
--- a/extensions/browser/app_sorting.h
+++ b/extensions/browser/app_sorting.h
@@ -109,8 +109,9 @@ class AppSorting {
virtual syncer::StringOrdinal PageIntegerAsStringOrdinal(
size_t page_index) = 0;
- // Hidden extensions don't appear in the new tab page.
- virtual void MarkExtensionAsHidden(const std::string& extension_id) = 0;
+ // Sets whether the extension should be visible in the new tab page.
tapted 2014/07/17 04:29:46 Perhaps, // Hides an extension from the new tab
tmdiep 2014/07/17 05:48:57 Done.
+ virtual void SetExtensionVisible(const std::string& extension_id,
+ bool visible) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(AppSorting);

Powered by Google App Engine
This is Rietveld 408576698