Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: extensions/browser/app_sorting.h

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review
Patch Set: Changed implementation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_APP_SORTING_H_ 5 #ifndef EXTENSIONS_BROWSER_APP_SORTING_H_
6 #define EXTENSIONS_BROWSER_APP_SORTING_H_ 6 #define EXTENSIONS_BROWSER_APP_SORTING_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // Convert the page StringOrdinal value to its integer equivalent. This takes 102 // Convert the page StringOrdinal value to its integer equivalent. This takes
103 // O(# of apps) worst-case. 103 // O(# of apps) worst-case.
104 virtual int PageStringOrdinalAsInteger( 104 virtual int PageStringOrdinalAsInteger(
105 const syncer::StringOrdinal& page_ordinal) const = 0; 105 const syncer::StringOrdinal& page_ordinal) const = 0;
106 106
107 // Converts the page index integer to its StringOrdinal equivalent. This takes 107 // Converts the page index integer to its StringOrdinal equivalent. This takes
108 // O(# of apps) worst-case. 108 // O(# of apps) worst-case.
109 virtual syncer::StringOrdinal PageIntegerAsStringOrdinal( 109 virtual syncer::StringOrdinal PageIntegerAsStringOrdinal(
110 size_t page_index) = 0; 110 size_t page_index) = 0;
111 111
112 // Hidden extensions don't appear in the new tab page. 112 // Sets whether the extension should be visible in the new tab page.
tapted 2014/07/17 04:29:46 Perhaps, // Hides an extension from the new tab
tmdiep 2014/07/17 05:48:57 Done.
113 virtual void MarkExtensionAsHidden(const std::string& extension_id) = 0; 113 virtual void SetExtensionVisible(const std::string& extension_id,
114 bool visible) = 0;
114 115
115 private: 116 private:
116 DISALLOW_COPY_AND_ASSIGN(AppSorting); 117 DISALLOW_COPY_AND_ASSIGN(AppSorting);
117 }; 118 };
118 119
119 } // namespace extensions 120 } // namespace extensions
120 121
121 #endif // EXTENSIONS_BROWSER_APP_SORTING_H_ 122 #endif // EXTENSIONS_BROWSER_APP_SORTING_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698