Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 397853002: Refactor safe-browsing build-config definitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup gn files Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 80332cbcb22c3fc1847c15eec97844fb64cb16c8..cc6e9faa38f71a0daed0e03df3f91e01311f5160 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -352,11 +352,12 @@
'../components/components.gyp:policy_test_support',
],
}],
- ['safe_browsing!=1', {
+ ['safe_browsing==0 or safe_browsing==2', {
'sources/': [
['exclude', '^browser/extensions/blacklist_unittest.cc'],
['exclude', '^browser/extensions/fake_safe_browsing_database_manager.cc'],
['exclude', '^browser/extensions/fake_safe_browsing_database_manager.h'],
+ ['exclude', '^browser/extensions/test_blacklist.cc'],
],
}],
['OS=="linux"', {
@@ -2282,13 +2283,8 @@
['exclude', '^browser/notifications/'],
],
}],
- ['safe_browsing==1', {
- 'defines': [
- 'FULL_SAFE_BROWSING',
- ],
- }],
# TODO(sgurun): enable tests for safe_browsing==2.
- ['safe_browsing!=1', {
+ ['safe_browsing==0 or safe_browsing==2', {
'sources/': [
['exclude', '^browser/safe_browsing/'],
['exclude', '^renderer/safe_browsing/'],

Powered by Google App Engine
This is Rietveld 408576698