Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_tests.gypi

Issue 397853002: Refactor safe-browsing build-config definitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup gn files Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h ('K') | « chrome/chrome_renderer.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | chrome/common/common_message_generator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 87e4d2753ce89ffe8891cc85e13dc01f751a2e6a..d6f15e9fb436f23c3b4788f1b9fb3d1c14f8e79b 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1800,19 +1800,8 @@
['exclude', '^../content/browser/speech/'],
],
}],
- ['safe_browsing==1', {
- 'defines': [
- 'FULL_SAFE_BROWSING',
- ],
- }],
- # TODO(sgurun) enable tests.
- ['safe_browsing==2', {
- 'sources/': [
- ['exclude', '^browser/safe_browsing/'],
- ['exclude', '^renderer/safe_browsing/'],
- ],
- }],
- ['safe_browsing==0', {
+ # TODO(sgurun) enable tests for safe_browsing==2.
+ ['safe_browsing==0 or safe_browsing==2', {
'sources/': [
['exclude', '^browser/safe_browsing/'],
['exclude', '^renderer/safe_browsing/'],
« chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h ('K') | « chrome/chrome_renderer.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | chrome/common/common_message_generator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698