components/policy/core/browser/url_blacklist_policy_handler_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_pref_store_unittest.cc ('k') | components/policy/core/common/cloud/cloud_policy_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

diff --git a/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc b/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

index fa52fbea4515fbb355fbe0925b5de850fe919201..282bbe42d01c581495783ae03fbc8eaa488a1305 100644

--- a/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

+++ b/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc

@@ -60,8 +60,8 @@ TEST_F(URLBlacklistPolicyHandlerTest,

TEST_F(URLBlacklistPolicyHandlerTest,

CheckPolicySettings_DisabledSchemesWrongType) {

// The policy expects a list. Give it a boolean.

- EXPECT_TRUE(CheckPolicy(key::kDisabledSchemes,

- base::Value::CreateBooleanValue(false)));

+ EXPECT_TRUE(

+ CheckPolicy(key::kDisabledSchemes, new base::FundamentalValue(false)));

EXPECT_EQ(1U, errors_.size());

const std::string expected = key::kDisabledSchemes;

const std::string actual = errors_.begin()->first;

@@ -71,8 +71,8 @@ TEST_F(URLBlacklistPolicyHandlerTest,

TEST_F(URLBlacklistPolicyHandlerTest,

CheckPolicySettings_URLBlacklistWrongType) {

// The policy expects a list. Give it a boolean.

- EXPECT_TRUE(CheckPolicy(key::kURLBlacklist,

- base::Value::CreateBooleanValue(false)));

+ EXPECT_TRUE(

+ CheckPolicy(key::kURLBlacklist, new base::FundamentalValue(false)));

EXPECT_EQ(1U, errors_.size());

const std::string expected = key::kURLBlacklist;

const std::string actual = errors_.begin()->first;

@@ -87,7 +87,7 @@ TEST_F(URLBlacklistPolicyHandlerTest, ApplyPolicySettings_NothingSpecified) {

TEST_F(URLBlacklistPolicyHandlerTest,

ApplyPolicySettings_DisabledSchemesWrongType) {

// The policy expects a list. Give it a boolean.

- SetPolicy(key::kDisabledSchemes, base::Value::CreateBooleanValue(false));

+ SetPolicy(key::kDisabledSchemes, new base::FundamentalValue(false));

ApplyPolicies();

EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));

}

@@ -95,7 +95,7 @@ TEST_F(URLBlacklistPolicyHandlerTest,

TEST_F(URLBlacklistPolicyHandlerTest,

ApplyPolicySettings_URLBlacklistWrongType) {

// The policy expects a list. Give it a boolean.

- SetPolicy(key::kURLBlacklist, base::Value::CreateBooleanValue(false));

+ SetPolicy(key::kURLBlacklist, new base::FundamentalValue(false));

ApplyPolicies();

EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));

}