tools/json_schema_compiler/test/simple_api_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/simple_api_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/simple_api_unittest.cc

diff --git a/tools/json_schema_compiler/test/simple_api_unittest.cc b/tools/json_schema_compiler/test/simple_api_unittest.cc

index f34b9fc258201e02554b59bebe55119e846f29ea..f75037dd27be8187e2dc9c789f905688c669ec64 100644

--- a/tools/json_schema_compiler/test/simple_api_unittest.cc

+++ b/tools/json_schema_compiler/test/simple_api_unittest.cc

@@ -18,8 +18,7 @@ static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {

base::Value::CreateIntegerValue(4));

value->SetWithoutPathExpansion("string",

base::Value::CreateStringValue("bling"));

- value->SetWithoutPathExpansion("boolean",

- base::Value::CreateBooleanValue(true));

+ value->SetWithoutPathExpansion("boolean", new base::FundamentalValue(true));

return value.Pass();

}