Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | chrome/browser/profiles/profile_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
diff --git a/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc b/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
index cd60671deb7f22605714d9f0112466b3ef3a5ef2..f0861c6b31f7e85dd43020678c7c7b39d05611c2 100644
--- a/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
+++ b/chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
@@ -33,10 +33,11 @@ class IncognitoModePolicyHandlerTest
int availability) {
PolicyMap policy;
if (incognito_enabled != INCOGNITO_ENABLED_UNKNOWN) {
- policy.Set(key::kIncognitoEnabled, POLICY_LEVEL_MANDATORY,
+ policy.Set(key::kIncognitoEnabled,
+ POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER,
- base::Value::CreateBooleanValue(
- incognito_enabled == INCOGNITO_ENABLED_TRUE),
+ new base::FundamentalValue(incognito_enabled ==
Lei Zhang 2014/07/15 22:19:28 nit: I like "incognito_enabled == ..." on the next
Evan Stade 2014/07/16 21:07:05 this is the output of git cl format
+ INCOGNITO_ENABLED_TRUE),
NULL);
}
if (availability >= 0) {
« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | chrome/browser/profiles/profile_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698