Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/json_schema_compiler/test/arrays_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/arrays_unittest.cc
diff --git a/tools/json_schema_compiler/test/arrays_unittest.cc b/tools/json_schema_compiler/test/arrays_unittest.cc
index 817e51c27e64243e9ba5a426dc17db248af7772a..9dfffe26fba8a2fc3ae219a79d259d0e220cad2f 100644
--- a/tools/json_schema_compiler/test/arrays_unittest.cc
+++ b/tools/json_schema_compiler/test/arrays_unittest.cc
@@ -24,8 +24,8 @@ static scoped_ptr<base::DictionaryValue> CreateBasicArrayTypeDictionary() {
integers_value->Append(base::Value::CreateIntegerValue(2));
integers_value->Append(base::Value::CreateIntegerValue(3));
base::ListValue* booleans_value = new base::ListValue();
- booleans_value->Append(base::Value::CreateBooleanValue(false));
- booleans_value->Append(base::Value::CreateBooleanValue(true));
+ booleans_value->Append(new base::FundamentalValue(false));
+ booleans_value->Append(new base::FundamentalValue(true));
base::ListValue* numbers_value = new base::ListValue();
numbers_value->Append(base::Value::CreateDoubleValue(6.1));
value->Set("numbers", numbers_value);

Powered by Google App Engine
This is Rietveld 408576698