components/policy/core/common/cloud/cloud_policy_manager_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc ('K') | « components/policy/core/browser/url_blacklist_policy_handler_unittest.cc ('k') | components/policy/core/common/policy_bundle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc b/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

index 274b95d6521d322e1d78d6664200b028f1204462..ff393dd9b5e8dfe78c0b2bcd66baa295c323a3bc 100644

--- a/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

@@ -101,8 +101,11 @@ void TestHarness::InstallIntegerPolicy(const std::string& policy_name,

void TestHarness::InstallBooleanPolicy(const std::string& policy_name,

bool policy_value) {

- store_.policy_map_.Set(policy_name, policy_level(), policy_scope(),

- base::Value::CreateBooleanValue(policy_value), NULL);

+ store_.policy_map_.Set(policy_name,

+ policy_level(),

+ policy_scope(),

+ new base::FundamentalValue(policy_value),

+ NULL);

}

void TestHarness::InstallStringListPolicy(const std::string& policy_name,