mojo: kill app_thread before unloading main app library and add tests

mojo/shell/mojo_url_resolver.h

Index: mojo/shell/mojo_url_resolver.h
diff --git a/mojo/shell/mojo_url_resolver.h b/mojo/shell/mojo_url_resolver.h
index d232a40703503105c5b32eba923f6f29ddba8600..bcf4b5588768627d75da41be68e6c189a566788d 100644
--- a/mojo/shell/mojo_url_resolver.h
+++ b/mojo/shell/mojo_url_resolver.h
@@ -24,7 +24,7 @@ class MojoURLResolver {
   // If specified, then unknown "mojo:" URLs will be resolved relative to this
   // origin. That is, the portion after the colon will be appeneded to origin
   // with platform-specific shared library prefix and suffix inserted.
-  void set_origin(const std::string& origin) { origin_ = origin; }
+  void SetOrigin(const std::string& origin);

[viettrungluu, 2014/07/15 22:44:53]

I wonder if this shouldn't take a GURL as an argument.

[tim (not reviewing), 2014/07/15 23:01:29]

Heh, do either of you know a handy way to force a trailing slash on a GURL
(aside from GURL::Replacements)? I'd like to have the base_url_ behavior be
consistent when it is set so we don't have to think about it later in Resolve
(it's also important because gurl.Resolve truncates to the last slash for file
URLs). I kept it to a string because this was trivial, but I agree a GURL would
be nice.

[tim (not reviewing), 2014/07/19 02:11:37]

Done.

 
   // Add a custom mapping for a particular "mojo:" URL.
   void AddCustomMapping(const GURL& mojo_url, const GURL& resolved_url);
@@ -40,7 +40,7 @@ class MojoURLResolver {
  private:
   std::map<GURL, GURL> url_map_;
   std::set<GURL> local_file_set_;
-  std::string origin_;
+  GURL origin_;
 };
 
 }  // namespace shell