mojo: kill app_thread before unloading main app library and add tests

mojo/shell/mojo_url_resolver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_MOJO_URL_RESOLVER_H_
 #define MOJO_SHELL_MOJO_URL_RESOLVER_H_
 
 #include <map>
 #include <set>
 
 #include "url/gurl.h"
 
 namespace mojo {
 namespace shell {
 
 // This class resolves "mojo:" URLs to physical URLs (e.g., "file:" and
 // "https:" URLs). By default, "mojo:" URLs resolve to a file location, but
 // that resolution can be customized via the AddCustomMapping method.
 class MojoURLResolver {
  public:
   MojoURLResolver();
   ~MojoURLResolver();
 
   // If specified, then unknown "mojo:" URLs will be resolved relative to this
   // origin. That is, the portion after the colon will be appeneded to origin
   // with platform-specific shared library prefix and suffix inserted.
-  void set_origin(const std::string& origin) { origin_ = origin; }
+  void SetOrigin(const std::string& origin);

[viettrungluu, 2014/07/15 22:44:53]

I wonder if this shouldn't take a GURL as an argument.

[tim (not reviewing), 2014/07/15 23:01:29]

Heh, do either of you know a handy way to force a trailing slash on a GURL
(aside from GURL::Replacements)? I'd like to have the base_url_ behavior be
consistent when it is set so we don't have to think about it later in Resolve
(it's also important because gurl.Resolve truncates to the last slash for file
URLs). I kept it to a string because this was trivial, but I agree a GURL would
be nice.

[tim (not reviewing), 2014/07/19 02:11:37]

Done.

 
   // Add a custom mapping for a particular "mojo:" URL.
   void AddCustomMapping(const GURL& mojo_url, const GURL& resolved_url);
 
   // Add a local file mapping for a particular "mojo:" URL. This causes the
   // "mojo:" URL to be resolved to an base::DIR_EXE-relative shared library.
   void AddLocalFileMapping(const GURL& mojo_url);
 
   // Resolve the given "mojo:" URL to the URL that should be used to fetch the
   // code for the corresponding Mojo App.
   GURL Resolve(const GURL& mojo_url) const;
 
  private:
   std::map<GURL, GURL> url_map_;
   std::set<GURL> local_file_set_;
-  std::string origin_;
+  GURL origin_;
 };
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_MOJO_URL_RESOLVER_H_