Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 397593002: Pass named argument 'default_parameters' to fix test_with_parameters in_file_unittest.py (Closed)

Created:
6 years, 5 months ago by vivekg_samsung
Modified:
6 years, 5 months ago
CC:
blink-reviews, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Pass named argument 'default_parameters' to fix test_with_parameters in_file_unittest.py This test case is failing as default_parameters is defaulted to 'None' due to its position after valid_values. Passing it as named argument fixes the failing case. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/build/scripts/in_file_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vivekg
PTAL, thanks!
6 years, 5 months ago (2014-07-15 10:00:59 UTC) #1
vivekg
This unit test case was added as per [1]. While implementing the CL [2], the ...
6 years, 5 months ago (2014-07-15 10:20:51 UTC) #2
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-15 21:08:55 UTC) #3
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-15 21:42:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/397593002/1
6 years, 5 months ago (2014-07-15 21:43:12 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 22:48:33 UTC) #6
Message was sent while issue was closed.
Change committed as 178212

Powered by Google App Engine
This is Rietveld 408576698