Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 15018018: Autogenerate lists of "stable", "experimental" and "test" features from RuntimeEnabledFeatures.in (Closed)

Created:
7 years, 7 months ago by eseidel
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, abarth-chromium, dglazkov
Visibility:
Public.

Description

This completes the transition of moving control over the set of "stable" features from Content down into Blink and making it autogenerated. I also needed to add value-validation to InFile parsing for this change. There is still more we could autogenerate here, but this covers most use-cases for contributors wanting to add experimental features to the tree and be able to easily turn them on/off. (And for API OWNERS being able to tell what we're actually shipping as part of the "stable" API.) I suspect we'll want to iterate on this file format further, once we've had some time to try it. I expect that many other systems may want to read this file (including possibly layout tests and the chrome feature status dashboard). We may want to change the default to be "test" instead of "off" as most "off" features actually end up enabled in some part of the product through other (non-standard or deprecated) ways up in Content. I will announce this on Blink dev once it's successfully integrated into the tree. BUG=237740 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149923

Patch Set 1 #

Patch Set 2 : Ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -90 lines) Patch
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -42 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 1 chunk +51 lines, -39 lines 0 comments Download
M Source/core/scripts/in_file.py View 1 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/scripts/in_generator.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/scripts/make_runtime_features.py View 1 5 chunks +40 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
ptal
7 years, 7 months ago (2013-05-07 23:28:29 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-07 23:33:07 UTC) #2
eseidel
7 years, 7 months ago (2013-05-08 01:13:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r149923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698